Use git -C instad of Dir.chdir #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def git(args, include_error: false) | ||
| command = 'git ' << args.join(' ') | ||
| def repo_git(args, include_error: false) | ||
| command = "git -C #{repo} " << args.join(' ') |
There was a problem hiding this comment.
Will this shell command get quoted properly?
|
What version of |
|
Looks like 1.8.5 |
Closed
1 task
|
I think system git is 2.7.4 Though this may be sierra specific |
|
Xcode 7 git is 2.7.4 as well. You can do the following to verify with your Xcode version: |
|
Looks like Xcode 8b6 git is 2.8.4. Haven't had a chance to check GM |
|
I doubt they'll jump back a major version, so that should be 👍 |
benasher44
force-pushed
the
basher_no_git_chdir
branch
from
2de478a
to
0ac13d7
Compare
4 tasks
Closed
1 task
|
GM is still git 2.8.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all of the git-related
Dir.chdirs. There's only one left, but I'm not sure that one is as easy to circumvent? This fixes issues related to CocoaPods not being able to find source repos and trying to re-create existing ones.