Check requires arc true false strings #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VinayGuthal please add LGTM. |
dnkoutso
reviewed
Jul 13, 2017
| # | ||
| def check_requires_arc_attribute | ||
| attributes = DSL.attributes.values | ||
| attributes.each do |attr| |
There was a problem hiding this comment.
can you just use attributes.find { |attr| attr.name == :requires_arc } instead?
dnkoutso
reviewed
Jul 13, 2017
| # @return [void] | ||
| # | ||
| def check_requires_arc_attribute | ||
| attribute = DSL.attributes.values.find{|attr| attr.name == :requires_arc} |
There was a problem hiding this comment.
is the formatting correct here? I think spaces are needed, rubocop -a I believe will take care of it for you.
… true or false add tests to test the functionality add tests use mangos instead of bananas update mango lib remove mango corp typo address comments udpate changelog run rubocop -a
VinayGuthal
force-pushed
the
check_requires_arc_true_false_strings
branch
from
16731ee
to
ce4734b
Compare
|
Yep, good idea
…On Jul 13, 2017 16:50, "Dimitris Koutsogiorgas" ***@***.***> wrote:
👌 !
@dantoml <https://github.com/dantoml> or @orta <https://github.com/orta>
quick check?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#393 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC_jt1QzAMua0vVqkb1J4njzKPjH4JPks5sNoMOgaJpZM4OXd-C>
.
|
|
Is there anything else that I need to take care of here? :) |
|
No, I don't think so, let's get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CocoaPods/CocoaPods#6701.
Add a warning if the strings
'true'or'false'are being used instead of booleantrueorfalseas the value for 'requires_arc' in the pod spec file.