-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requires_app_host
DSL attribute
#399
Conversation
9743729
to
b095b5b
Compare
b095b5b
to
6e43de0
Compare
Hm I dont think this is right. Using the |
requires_app_host
DSL attributerequires_app_host
DSL attribute
6e43de0
to
fd38e09
Compare
requires_app_host
DSL attributerequires_app_host
DSL attribute
@segiddins @dantoml if interested I believe this is now ready! |
def _validate_test_type(t) | ||
unless consumer.spec.test_specification? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this moved to the analyzer.rb
and will check all test_only
attributes that should be part only within test specifications.
@@ -253,28 +253,6 @@ def result_should_include(*values) | |||
|
|||
#------------------# | |||
|
|||
it 'checks that test type cannot be set at the root spec' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer needed, analyzer takes care of this.
Here's the JSON {
"name": "CannonPodder",
"version": "1.0.1",
"summary": "Small library that can be used to test CocoaPod stuff (CI, building etc.)",
"homepage": "https://stash.corp.something.com/projects/IOS/repos/cannonpodder/browse",
"license": {
"type": "Proprietary",
"text": "© 2017 Something, Inc."
},
"authors": {
"Someone": "someone@something.com"
},
"source": {
"git": "https://stash.corp.somewhere.com/scm/ios/cannonpodder.git",
"tag": "1.0.1"
},
"platforms": {
"ios": "9.0",
"osx": "10.10"
},
"source_files": "Sources/**/*.{h,m}",
"testspecs": [
{
"name": "Tests",
"test_type": "unit",
"source_files": "Tests/**/*.{h,m}",
"requires_app_host": true
}
]
} |
Will a pre-1.3 JSON parser for a podspec ignore this? |
Yes. Should be fine because it doesn't even have any logic for app hosts and test specs |
yay! thank you! |
No description provided.