Improve performance of Pod::Source#search

[dnkoutso]

Within source.rb, just by calling:

    def search(query)
      unless specs_dir
        raise Informative, "Unable to find a source named: `#{name}`"
      end
      if query.is_a?(Dependency)
        query = query.root_name
      end
      found = Pathname.glob(pod_path(query)).map { |path| path.basename.to_s }
      if [query] == found
        set = set(query)
        set if set.specification.name == query # <----------------- this line
      end
    end

It calls Pod::Specification::Set#specification which will call twice the expensive highest_version_spec_path method.

There is no need for us to get the highest version spec if the only thing we need is the name of the specification, which should not be any different given all Podspec names are unique.

This actually saves about 7%-9% in pod install time for a large project that contains a specific pod with 200+ versions (we publish a version nightly). It brought down our pod install from ~53 seconds to ~48 seconds.

set.rb appears immutable so there is no need to evict any of the caching.

[dnkoutso]

paired with @justinseanmartin on this.

[segiddins]

this should probably be private?

[dnkoutso]

done

[dnkoutso]

green!