Windows support #466
Merged
Windows support #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
reviewed
Oct 15, 2018
lib/cocoapods-core/source/manager.rb
Outdated
| @@ -234,6 +234,11 @@ def update_search_index_if_needed(changed_spec_paths) | |||
| # A hash containing changed specification paths for each source. | |||
| # | |||
| def update_search_index_if_needed_in_background(changed_spec_paths) | |||
| if Gem.win_platform? | |||
| update_search_index_if_needed(changed_spec_paths) | |||
| exit | |||
There was a problem hiding this comment.
Copy-paste bug - since it's one of the last things happening during the update, didn't catch it. Fixing and pushing with rebase.
|
@segiddins - I have rebased and force-pushed a fix removing the spurious "exit" you have mentioned (I guess I should have waited to squash until after all the reviews :)) |
paulb777
reviewed
Oct 16, 2018
CHANGELOG.md
Outdated
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * Windows support - do not use fork when updating the index | |||
| [David Airapetyan](https://github.com/davidair) | |||
There was a problem hiding this comment.
Fix indenting to match others and add the PR link line.
amorde
reviewed
Oct 25, 2018
amorde
approved these changes
Oct 25, 2018
|
Squashed all the commits into one, rebased to remove the merges |
Forks are not supported on windows - making sure we don't crash CocoaPods/CocoaPods#8189 has the rest of support
dnkoutso
approved these changes
Nov 6, 2018
dnkoutso
reviewed
May 7, 2019
| @@ -15,6 +15,10 @@ | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * Windows support - do not use fork when updating the index | |||
There was a problem hiding this comment.
This was in the wrong spot. Updated to reflect correct release which was 1.7.0.beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forks are not supported on windows - making sure we don't crash