Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linter] Cleanup the linter #50

Merged
merged 11 commits into from
Apr 1, 2014
Merged

[Linter] Cleanup the linter #50

merged 11 commits into from
Apr 1, 2014

Commits on Dec 6, 2013

  1. Move the Linter::Result class into its own file. 

    Clears up a bit of the clutter inside of linter.rb and makes it clearly
it's own entity within the linter.
    @joshkalpin
    joshkalpin committed Dec 6, 2013
    1 Configuration menu
    Copy the full SHA
    6b3de00 View commit details
    Browse the repository at this point in the history

  2. De-duplicate validation methods inside of the linter 

    Validation hook runners were essentially the same except by whom they
were targetting.
    @joshkalpin
    joshkalpin committed Dec 6, 2013
    1 Configuration menu
    Copy the full SHA
    b24e8d8 View commit details
    Browse the repository at this point in the history

  3. Remove extra commas in empty error message

    @joshkalpin
    joshkalpin committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    fb4d69f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2013

  1. Move the result helpers into the result file

    @joshkalpin
    joshkalpin committed Dec 7, 2013
    Configuration menu
    Copy the full SHA
    b63f2e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2013

  1. Create an analyzer to encapsulate all specs analysis 

    tldr; moved a ton of code out of the linter into another class.

TODOS:
- Create a results mixin
- Separate out the validation into two sections for both consumers and
  specs
- Make sure documentation is good
    @joshkalpin
    joshkalpin committed Dec 10, 2013
    5 Configuration menu
    Copy the full SHA
    07bb50e View commit details
    Browse the repository at this point in the history

  2. Convert the result helpers to a mixin

    @joshkalpin
    joshkalpin committed Dec 10, 2013
    4 Configuration menu
    Copy the full SHA
    d22bca6 View commit details
    Browse the repository at this point in the history

  3. Make only the results property public

    @joshkalpin
    joshkalpin committed Dec 10, 2013
    Configuration menu
    Copy the full SHA
    8fa24d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2014

  1. Merge branch 'master' into linter-refactor 

    Conflicts:
	spec/specification/linter_spec.rb
    @joshkalpin
    joshkalpin committed Jan 14, 2014
    Configuration menu
    Copy the full SHA
    2f85c66 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2014

  1. Merge branch 'master' into linter-refactor 

    Conflicts:
	lib/cocoapods-core/specification/linter.rb
	spec/specification/linter_spec.rb
    @joshkalpin
    joshkalpin committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    b597fc1 View commit details
    Browse the repository at this point in the history

  2. Remove redundant specs from the linter. 

    Porting over the last of the linter specs that are now used by the
analyzer over.
    @joshkalpin
    joshkalpin committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    ea328ea View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into linter-refactor 

    Conflicts:
	lib/cocoapods-core/specification/linter.rb
    @joshkalpin
    joshkalpin committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    780dcfc View commit details
    Browse the repository at this point in the history