Ensure test_type value is converted to a symbol from consumer
#504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test for this fix? |
dnkoutso
force-pushed
the
fix_test_type_consumer_value
branch
from
2acfcd8
to
de7974d
Compare
|
Test added verified it goes red without my change and green with it. |
amorde
approved these changes
Jan 8, 2019
dnkoutso
force-pushed
the
fix_test_type_consumer_value
branch
from
2425474
to
717cb30
Compare
dnkoutso
force-pushed
the
fix_test_type_consumer_value
branch
from
717cb30
to
5b6f4a7
Compare
|
This did not make it to the 1.6.x release. Updating milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb#L289...
...we now use the consumer of the spec to read the value. Unfortunately the value that comes back from the consumer for JSON podspecs can be a string which cascades into other failures.
This fixes this and all subsequent callsites.