Replace git-based MasterSource with CDN-based TrunkSource #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-makarov
force-pushed
the
cdn-master-source
branch
12 times, most recently
from
b66c786
to
168b682
Compare
igor-makarov
changed the title
igor-makarov
force-pushed
the
cdn-master-source
branch
from
35f82ab
to
b9d29bf
Compare
dnkoutso
reviewed
Jun 27, 2019
dnkoutso
reviewed
Jun 27, 2019
dnkoutso
approved these changes
Jun 27, 2019
|
Sorry for the blast of reviewers. I just think one more person should take a look for swapping out the master source! This is super exciting. |
|
Thank you! |
igor-makarov
force-pushed
the
cdn-master-source
branch
from
b9d29bf
to
e55b53a
Compare
amorde
reviewed
Jun 27, 2019
|
Fixed some edge cases in CDN URL handling + added a few tests for the trailing slashes/newlines in CDN URL. |
|
Please rebase now that 1.7.3 is released and ensure |
igor-makarov
force-pushed
the
cdn-master-source
branch
from
fc7f3ea
to
4dc084a
Compare
|
Rebased Core, CocoaPods and Integration. 💪 |
amorde
approved these changes
Jul 1, 2019
|
@igor-makarov just need a rebase and we can land. |
…like a find/replace accident
use Artsy spec repo in aggregate tests
igor-makarov
force-pushed
the
cdn-master-source
branch
from
4dc084a
to
1e2ff65
Compare
|
Done! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CocoaPods#8923 for more info.