Do not alter swift_versions attribute when calculating Swift versions.
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
omg_attributes_hash_fix
branch
from
f1f63b4
to
2fc4003
Compare
dnkoutso
commented
Sep 27, 2019
| first_hash['swift_version'].should == '5.0' | ||
| spec_from_hash = Specification.from_hash(first_hash) | ||
| second_hash = spec_from_hash.to_hash | ||
| second_hash['swift_versions'].should == ['4.2', '5.0'] |
There was a problem hiding this comment.
verified this fails without my actual change.
There was a problem hiding this comment.
Without the change this returns: ['4.2', '5.0', '5.0']
dnkoutso
commented
Sep 27, 2019
| @@ -47,7 +47,7 @@ def swift_version | |||
| # | |||
| def swift_versions | |||
| @swift_versions ||= begin | |||
| swift_versions = Array(attributes_hash['swift_versions']) | |||
| swift_versions = Array(attributes_hash['swift_versions']).dup | |||
There was a problem hiding this comment.
further below we do:
swift_versions << attributes_hash['swift_version'] unless attributes_hash['swift_version'].nil?At this point swift_versions points to the original array and it actually alters the internal structure of the specification.
There was a problem hiding this comment.
tbh I didn't realize this would ever alter the original structure. TIL.
There was a problem hiding this comment.
Yeap. Array() doesn't make a new one if what we are parsing is already an array....🤦♂
amorde
approved these changes
Sep 27, 2019
| @@ -47,7 +47,7 @@ def swift_version | |||
| # | |||
| def swift_versions | |||
| @swift_versions ||= begin | |||
| swift_versions = Array(attributes_hash['swift_versions']) | |||
| swift_versions = Array(attributes_hash['swift_versions']).dup | |||
There was a problem hiding this comment.
tbh I didn't realize this would ever alter the original structure. TIL.
segiddins
approved these changes
Sep 27, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.