Make initializing Platform with a string 'macos' behave the same as Platform.macos
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `Platform.macos`
amorde
commented
Oct 24, 2019
| @@ -29,8 +29,14 @@ module Pod | |||
| end | |||
|
|
|||
| it 'can be initialized with a string symbolic name' do | |||
| Platform.new('ios') | |||
| @platform.name.should == :ios | |||
| platform = Platform.new('ios') | |||
There was a problem hiding this comment.
this was initializing a new platform and throwing it away, and then checking state initialized elsewhere. not an effective test
dnkoutso
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for
Platformconsumers to usePlatform.newto parse values from JSON, Info.plist files, etc. without having to manually mapmacos=>osxin order for it to successfully match other platforms defined within CocoaPods.