Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume all responses have headers #607

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Don't assume all responses have headers #607

merged 1 commit into from
Jan 30, 2020

Conversation

amorde
Copy link
Member

@amorde amorde commented Dec 14, 2019

No description provided.

@amorde amorde requested a review from dnkoutso December 14, 2019 02:05
@amorde amorde closed this Dec 14, 2019
@amorde amorde reopened this Dec 14, 2019
segiddins
segiddins approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a test added

@dnkoutso dnkoutso added this to the 1.9 milestone Dec 16, 2019
@dnkoutso
Copy link
Contributor

dnkoutso commented Jan 5, 2020

Is this a 1.9 fix? If so we can target the 1-9-stable branch.

@amorde
Copy link
Member Author

amorde commented Jan 5, 2020

Ah yeah, can do

@amorde
Copy link
Member Author

amorde commented Jan 5, 2020

Tests won't pass until #609 is merged or something else fixes the tests

@amorde amorde changed the base branch from master to 1-9-stable January 5, 2020 02:27
@dnkoutso
Copy link
Contributor

dnkoutso commented Jan 5, 2020

Should we add a changelog entry? I.e is this a bug fix?

@amorde
Copy link
Member Author

amorde commented Jan 5, 2020

yes, good catch

@dnkoutso
Copy link
Contributor

@amorde can you rebase for 1-9-stable since CI is fixed? I will merge and ship for 1.9.0.beta.3.

@amorde
Copy link
Member Author

amorde commented Jan 30, 2020

Yep can do

@dnkoutso
Copy link
Contributor

dnkoutso commented Jan 30, 2020 •
edited
Loading

@amorde just rubocopster failing

@dnkoutso dnkoutso merged commit a356141 into 1-9-stable Jan 30, 2020
@dnkoutso dnkoutso deleted the amorde/cdn-source branch January 30, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segiddins segiddins segiddins approved these changes

@dnkoutso dnkoutso dnkoutso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@amorde @dnkoutso @segiddins