Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDNSource - Run a rudimentary local check to help with CDN client robustness #632

Merged
merged 3 commits into from
May 25, 2020
Merged

CDNSource - Run a rudimentary local check to help with CDN client robustness #632

merged 3 commits into from
May 25, 2020

Conversation

igor-makarov
Copy link
Contributor

@igor-makarov igor-makarov commented May 25, 2020 •
edited
Loading

  • Use a robust local check (file exists and is nonzero length) to ensure it's okay.
  • Use same check to decide whether to use eTag (so that if file doesn't exist the eTag is disregarded).

Possibly closes CocoaPods/CocoaPods#9814

@dnkoutso dnkoutso merged commit 52e3b59 into CocoaPods:1-9-stable May 25, 2020
@dnkoutso dnkoutso added this to the 1.9.3 milestone May 25, 2020
@igor-makarov igor-makarov deleted the fix-empty-files branch May 26, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-makarov @dnkoutso