Fix warnings in dependency.rb
#720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
commented
Mar 21, 2022
Comment on lines
-106
to
+108
| attr_accessor :specific_version | ||
| attr_reader :specific_version |
There was a problem hiding this comment.
Fixes warning: method redefined; discarding old ... warning.
Comment on lines
+102
to
+103
| @specific_requirement ||= nil | ||
| @external_source ||= nil |
There was a problem hiding this comment.
Fixes both warning: instance variable ... not initialized warnings.
|
The CI issue we have not yet identified. Its for Ruby 3.0, going to merge this for now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency.rbhas a few warnings that are showing up locally and in CI whenpod lib linting.For example, see https://github.com/firebase/firebase-ios-sdk/runs/5619185788?check_suite_focus=true.
warning: method redefined; discarding old ...warning: instance variable ... not initializedcc: @paulb777