-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring CDN requests max concurrency to reduce flakiness #773
Conversation
@santam85 FYI you might encounter similar issue depending on your setup when using Artifactory CDN if your local repository is containing large amount of indexed specs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with a changelog entry
beec95a
to
95152b0
Compare
95152b0
to
ec7ef6f
Compare
@segiddins thanks for reviewing, added the changelog entry accordingly. |
@amorde sorry for tagging, but I noticed you were recently supporting merging PRs. would you mind to please take care of this one as well? thanks in advance! |
@amorde would you mind to recheck it again and merge it? thanks! |
@amorde sorry for asking again, but would you mind to recheck it and merge it? thanks a lot! |
@segiddins would you mind to merge this PR as well? thanks! |
Thanks @segiddins ❤️ ! Do you know by chance if there is a plan to produce a new release as well soon? |
@amorde would it be an option to include new version of core package as part of next CocoaPods release? Thanks! |
Introducing
COCOAPODS_CDN_MAX_CONCURRENCY
configuration point to reduce the maximum concurrency of Hydra. The default max concurrency (200) can lead to flakiness like DNS resolution failure being marked as DoS attack OR missing authorization headers. This flakiness is also remarked in the documentation of typhoeus library.