FileSystemDataProvider::pods - ignore any entry that begins with a period #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely cleaner. Can you add a few simple tests for .svn and .hg so we never regress on that and also add a CHANGELOG entry crediting yourself? |
|
Good call but we need also to add a check to the linter which prevents Pods names starting with the |
|
This can be merged as soon as the entry in the Changelog is added. |
|
I'm going to update pod lib create to disallow |
|
@clarkda... sounds really good... I would never have thought about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I've added SVN repo support in a plugin and one of the issues I have is linting the SVN spec repo. I think this will be a little cleaner than adding individual cases that deal with .svn, .hg, etc metadata.
Let me know what you think, thanks!