Format synchronized root groups as flat dictionary #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robnadin
force-pushed
the
fix-synchronized-folders
branch
from
071aaa3 to
5f5c2f3
Compare
robnadin
force-pushed
the
fix-synchronized-folders
branch
from
5f5c2f3 to
5aa1691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed in a custom project some discrepancies in how some of the new synchronized folder objects are being formatted after running
pod install.Looking at the differences, I believe the fix is to add
PBXFileSystemSynchronizedRootGroupto the list of objects that should be considered to have a flat dictionary alongside the existingPBXBuildFileandPBXFileReferencetypes.There is additional changes that need to be made to the Xcodeproj dependency too for this issue to be fully resolved when using CocoaPods, that I will do so in an associated PR to that repository shortly. My current changes made there can be viewed here.