-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping last known Xcode version to 5.1 #138
Conversation
Before we bump the version we’ll have to see if we need to make any actual defaults changes. Does Xcode want you to update any values besides bumping the version? |
Yes, it does. It removes architectures setting to drop them to default ones (which after that may contradict the main project settings). Since pods architectures are generated based on main project architectures, I believed this behaviour should not change, thus only the version bump. Diff looks like this:
|
It’s true that CocoaPods will override that, but Xcodeproj is used outside of CocoaPods as well and as such we should follow what Xcode does. Can you add the new default here and also add a ChangeLog entry crediting yourself for updating to Xcode 5.1 defaults? |
Docs are kind of a struggle, is there a way to test creation of a dummy project to see defaults? Calling |
Also, do you update changelog by hand or with a script? ) |
@coverback Yes, the change log is a manual process. I think the CocoaPod's contributing document should apply to this repository. |
Ah indeed, I just created a new project with Xcode 5.1 and the default setting is completely blank inheriting default SDK settings. One final point, the test suite is failing because of this change. Are you familiar with Ruby and if so can you fix this please? |
That was silly of me. I thought that master is failing as stated on homepage and assumed it wasn't caused by this code. |
I restarted the build, it’s passing now except for one build related to a Ruby version not being available anymore. Thanks! |
Bumping last known Xcode version to 5.1
Great! Any estimate how fast it makes to gems repos? You're probably going to wait for more fixes or features? |
Now that Xcode 5.1 is released, pods created with '0500' version show up with "Validate project settings" warning. Bumping version fixes that.