Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping last known Xcode version to 5.1 #138

Merged
merged 1 commit into from
Mar 18, 2014
Merged

Bumping last known Xcode version to 5.1 #138

merged 1 commit into from
Mar 18, 2014

Conversation

karpelcevs
Copy link
Contributor

Now that Xcode 5.1 is released, pods created with '0500' version show up with "Validate project settings" warning. Bumping version fixes that.

@alloy
Copy link
Member

alloy commented Mar 17, 2014

Before we bump the version we’ll have to see if we need to make any actual defaults changes. Does Xcode want you to update any values besides bumping the version?

@karpelcevs
Copy link
Contributor Author

Yes, it does. It removes architectures setting to drop them to default ones (which after that may contradict the main project settings). Since pods architectures are generated based on main project architectures, I believed this behaviour should not change, thus only the version bump.

Diff looks like this:

--- Pods.xcodeproj/backup.pbxproj       2014-03-17 12:10:56.000000000 +0200
+++ Pods.xcodeproj/project.pbxproj      2014-03-17 12:11:07.000000000 +0200
@@ -6298,7 +6298,7 @@
                7F17A5370E524DD7BBEFAEB7 /* Project object */ = {
                        isa = PBXProject;
                        attributes = {
-                               LastUpgradeCheck = 0500;
+                               LastUpgradeCheck = 0510;
                        };
                        buildConfigurationList = 8269ECC110BF45EFB5CB72CF /* Build configuration list for PBXProject "Pods" */;
                        compatibilityVersion = "Xcode 3.2";
@@ -7473,7 +7473,6 @@
                        baseConfigurationReference = 77218E086D8641F5B0E5CEB7 /* Pods-app-tests-Quantcast-Measure-Private.xcconfig */;
                        buildSettings = {
                                ALWAYS_SEARCH_USER_PATHS = NO;
-                               ARCHS = "$(ARCHS_STANDARD_32_BIT)";
                                COPY_PHASE_STRIP = NO;
                                DSTROOT = /tmp/xcodeproj.dst;
                                GCC_C_LANGUAGE_STANDARD = gnu99;

@alloy
Copy link
Member

alloy commented Mar 17, 2014

It’s true that CocoaPods will override that, but Xcodeproj is used outside of CocoaPods as well and as such we should follow what Xcode does.

Can you add the new default here and also add a ChangeLog entry crediting yourself for updating to Xcode 5.1 defaults?

@karpelcevs
Copy link
Contributor Author

constants.rb doesn't have ARCHS variable set, it is being set up through native_target_spec.rb only, so I believe it means there isn't a default value, right? In that case it is same as Xcode 5.1 behaviour.
In that case, should some other files be updated? I updated CHANGELOG.md.

Docs are kind of a struggle, is there a way to test creation of a dummy project to see defaults? Calling new just returns a project with UUID only, no other defaults set.

@karpelcevs
Copy link
Contributor Author

Also, do you update changelog by hand or with a script? )

@kylef
Copy link
Contributor

kylef commented Mar 17, 2014

@coverback Yes, the change log is a manual process. I think the CocoaPod's contributing document should apply to this repository.

@alloy
Copy link
Member

alloy commented Mar 17, 2014

so I believe it means there isn't a default value, right? In that case it is same as Xcode 5.1 behaviour.

Ah indeed, I just created a new project with Xcode 5.1 and the default setting is completely blank inheriting default SDK settings.

One final point, the test suite is failing because of this change. Are you familiar with Ruby and if so can you fix this please?

@karpelcevs
Copy link
Contributor Author

One final point, the test suite is failing because of this change. Are you familiar with Ruby and if so can you fix this please?

That was silly of me. I thought that master is failing as stated on homepage and assumed it wasn't caused by this code.
I fixed the tests now, however CI still reports as error. Is there something else I should do?

@alloy
Copy link
Member

alloy commented Mar 18, 2014

I restarted the build, it’s passing now except for one build related to a Ruby version not being available anymore.

Thanks!

alloy added a commit that referenced this pull request Mar 18, 2014
Bumping last known Xcode version to 5.1
@alloy alloy merged commit 995ade2 into CocoaPods:master Mar 18, 2014
@karpelcevs
Copy link
Contributor Author

Great! Any estimate how fast it makes to gems repos? You're probably going to wait for more fixes or features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants