Minor API Improvements #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| def symbol_dst_subfolder_spec=(value) | ||
| numeric_value = Constants::COPY_FILES_BUILD_PHASE_DESTINATIONS[value] | ||
| raise "[Xcodeproj] Value checking error: got `#{value.inspect}` for" \ |
There was a problem hiding this comment.
Should this be an Informative or some more specific exception class?
There was a problem hiding this comment.
We use in Xcodeproj mainly just StandardError.
There was a problem hiding this comment.
Yes, Informative class is from CocoaPods itself and Xcodeproj is a standalone gem.
|
👍 |
|
@mrackwitz want to address Fabio's comments so we can merge? |
|
@segiddins: Thanks for the reminder. I will adress them soon. |
mrackwitz
force-pushed
the
minor_api_improvements
branch
from
18d8f94 to
feb8db2
Compare
mrackwitz
added a commit
that referenced
this pull request
Jan 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those API improvements will be helpful in an upcoming version of CocoaPods. 😉