-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Project] Add method to stabilize UUIDs #283
Conversation
ce9bec7
to
7f39e20
Compare
\c @alloy @kylef @orta @neonichu @mrackwitz I know the diff is small, and it needs some more tests, but I think it works. |
cool! |
Awesome! Yeah I'd like to see some tests for various types of objects. The doc should also state that it changes the uuids of objects and thus the user should not depend on being able to find them by uuid afterwards. |
Awesome 🎉 |
Hi, I'm sorry to intrude, just wanted to mention that original Xcode And a question regarding your logic of UUID generation: if I have two references pointing to the same file in the project, does it mean the generated UUID will be the same for both of them? |
@zats the issue with Xcode's UUID generation is that it's meant to be unique -- it includes a time stamp component. As to your question, they shouldn't be -- thanks to the distinction between PBXFileReferences and PBXBuildFiles, this should be fine. |
oh I see, thanks for the explanation! |
85ed1eb
to
70e9365
Compare
@@ -409,6 +410,12 @@ def uuids | |||
objects_by_uuid.keys | |||
end | |||
|
|||
# @note this should only be used for entirely machine-generated projects | |||
# | |||
def predictabilize_uuids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a counter-part PR using this in CocoaPods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… script build phases
Also makes paths slightly more pleasant strings
70e9365
to
44ec7bc
Compare
44ec7bc
to
010224e
Compare
[Project] Add method to stabilize UUIDs
I think I'm experiencing an issue with deterministic UUIDs here, do you have an idea what might be wrong here @segiddins ? |
Closes #175