Adding .hxx to the list of recognized header file extensions #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems 👍 to me |
|
Thanks for the pull request @jasonvasquez. Would you be able to add a short piece to the CHANGELOG so you get credit for this change please. |
jasonvasquez
force-pushed
the
hxx-as-headers
branch
from
9845301 to
d3ad609
Compare
jasonvasquez
force-pushed
the
hxx-as-headers
branch
from
d3ad609 to
f5477ba
Compare
|
done - thanks! |
|
Awesome. Until the next CocoaPod's release I'd advise you to stick to the prepare_command. Once it's out you can use it, but I would ensure you mark that your Pod would require X version of CocoaPods or newer to ensure that it isn't used on previous CocoaPod's installs. For example: spec.cocoapods_version = '>= 1.0.0'https://guides.cocoapods.org/syntax/podspec.html#cocoapods_version |
kylef
added a commit
that referenced
this pull request
Oct 23, 2015
Adding .hxx to the list of recognized header file extensions
|
Good idea - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a few cases with some third party open source libraries I'm wrapping in Cocoapods, where they use
.hxxas a header extension in C++ projects. I have .podspecprepare_command's to actually rename all the files and update references to them, otherwise, we generate build rules for all the.hxxfiles. That is obviously not optimal. Xcode recognizes these as headers already, we just need to slot them in the right build phase.