Support for identifying hosts of embedded targets from sub-projects #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like travis failed installing json. No gem dep changes here. |
|
Same issue. |
| # | ||
| def native_target_uuid | ||
| return target.uuid if target | ||
| return target_proxy.remote_global_id_string if target_proxy |
There was a problem hiding this comment.
maybe raise otherwise to ensure this doesn't return nil?
There was a problem hiding this comment.
This is actually fixed in the line below, but it didn't close this comment since I didn't change these lines :)
|
👍 |
|
@benasher44 this should pass with a rebase |
benasher44
force-pushed
the
basher_embedded_remote_target
branch
from
5a24a39 to
346a751
Compare
|
This is ready on my end! Once this is merged, I can update CocoaPods/CocoaPods#5637 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to fixing CocoaPods/CocoaPods#5622