[Fixtures] Updated CommonBuildSettings with Xcode 8.2.1 #468
Conversation
louisdh
changed the title
|
Spec failures now at 19 (down from 46) |
|
All spec failures have been resolved, but now Rubocop is complaining 😕 |
|
CI is happy now 😪 |
lib/xcodeproj/constants.rb
Outdated
| 'SWIFT_OPTIMIZATION_LEVEL' => '-Onone', | ||
| 'SWIFT_ACTIVE_COMPILATION_CONDITIONS' => 'DEBUG', | ||
| }.freeze, | ||
| [:release, :application, :swift] => { |
There was a problem hiding this comment.
The separate entry for applications shouldn't be necessary
There was a problem hiding this comment.
You're right, removed it
| @@ -3,15 +3,17 @@ | |||
| @implementation ViewController | |||
|
|
|||
| - (void)viewDidLoad { | |||
| [super viewDidLoad]; | |||
| [super viewDidLoad]; | |||
There was a problem hiding this comment.
What's with all these indentation changes?
There was a problem hiding this comment.
Ah, my Xcode settings seem to use tabs, but that doesn't really matter here does it? (basically unused code)
There was a problem hiding this comment.
Do you want me to change the indentation to spaces?
There was a problem hiding this comment.
Indentation has been changed to 4 spaces.
|
@segiddins Anything else you'd like to see different? |
|
@segiddins Can this be merged? |
|
Looks good to me |
|
@louisdh thanks! |
|
@louisdh with the release of Xcode 8.3, we'd certainly appreciate another PR if you find that there are more settings that need updating! :) |
|
Ok, I'll take a look. I'm glad this got merged since the diff. between 8.2.1 and 8.3 will be much smaller than this PR 🙂 |
|
I agree :). Thanks again for having a look! |
Updated Common Build Settings with Xcode 8.2.1.
Also updated gems to fix
bundler install.This updates the default build settings. Including the default optimization level for Swift release targets, which is now whole module optimization.