Configuring targets for running uses internal methods allowing commad line tools and apps to be launchable. #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, is it possible to add tests? |
|
YEah i'll add some tests |
dostrander
force-pushed
the
derko/apps-runnable
branch
from
7a66140 to
817b4eb
Compare
dostrander
changed the title
dostrander
force-pushed
the
derko/apps-runnable
branch
2 times, most recently
from
3a2042a to
0ae5ffb
Compare
dnkoutso
approved these changes
Oct 8, 2018
dostrander
force-pushed
the
derko/apps-runnable
branch
from
0ae5ffb to
95d38ce
Compare
segiddins
reviewed
Oct 8, 2018
CHANGELOG.md
Outdated
| @@ -65,7 +68,9 @@ | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * None. | |||
| * Add support for launchable targets from a scheme. | |||
dnkoutso
reviewed
Oct 8, 2018
…d line tools and apps to be executable.
dostrander
force-pushed
the
derko/apps-runnable
branch
from
95d38ce to
c3a0285
Compare
segiddins
approved these changes
Oct 9, 2018
joshuapoq
reviewed
Oct 23, 2018
| set_launch_target(runnable_target) if launch_target | ||
| end | ||
| if test_target | ||
| add_build_target(test_target, false) if test_target != runnable_target |
There was a problem hiding this comment.
This change has made our builds fail. Test targets are now added to the archive and are unable to code-sign? Was this intended?
As build_targets have profile, archive... all turned on?
There was a problem hiding this comment.
@joshuapoq could you submit a new issue with steps to reproduce?
There was a problem hiding this comment.
Sorry about that, will take al ook this afternoon
There was a problem hiding this comment.
No problem! I've raised an issue for this - let me know if any more info is required: #618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@segiddins @dnkoutso