Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes path issues with CMake generated projects #632

Closed
wants to merge 1 commit into from

Conversation

mad-rain
Copy link

Hi!

Please see CocoaPods/CocoaPods#6268 for more info.

@CocoaPodsBarista
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.

Here's an example of your CHANGELOG entry:

* Fixes path issues with CMake generated projects  
  [mad-rain](https://github.com/mad-rain)
  [#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@segiddins
Copy link
Member

Can you please add a changelog entry and a test for this change? Thanks!

@dnkoutso
Copy link
Contributor

dnkoutso commented May 2, 2019

@mad-rain ping here.

@mad-rain
Copy link
Author

mad-rain commented May 3, 2019

@dnkoutso, unfortunately I have limited time to spend on this issue and I have zero Ruby experience. Any help is appreciated!

@amorde
Copy link
Member

amorde commented May 5, 2019

@mad-rain we can help out with tests, but I (personally) had a hard time following the issue that was mentioned. It sounded like CMake generates projects in a certain directory, and settings PROJECT_DIR to something that doesn't work with CocoaPods.

Do you have an easy example that we can try to reproduce the issue?

@jothepro
Copy link

@amorde I created a small example project for you to demonstrate the issue. Hope this helps :)
@mad-rain Pls check the code to ensure were talking about the same thing!

https://github.com/jothepro/cocoapods_cmake_issue

@paulb777
Copy link
Member

Continued in #739

@paulb777 paulb777 closed this Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants