Add option for disabling dependency analysis in run phase #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LemonSpike
changed the title
dnkoutso
reviewed
Sep 29, 2020
| # PBXShellScriptBuildPhase as `Based on | ||
| # dependency analysis` (selected by default). | ||
| # | ||
|
|
dnkoutso
reviewed
Sep 29, 2020
CHANGELOG.md
Outdated
| @@ -7,6 +7,9 @@ | |||
| * Add support of c++ files (`hpp` and `cpp`) in `PBXFileReference:set_last_known_file_type`. | |||
| [romanmikhailov](https://github.com/romanmikhailov) | |||
| [#783](https://github.com/CocoaPods/Xcodeproj/issues/783) | |||
| * Add support of dependency analysis option in `PBXShellScriptBuildPhase:always_out_of_date`. | |||
There was a problem hiding this comment.
nit: add one line here.
Also add two empty spaces at the end of this line for markdown formatting.
dnkoutso
reviewed
Sep 29, 2020
|
Need to run |
|
Can you also rebase/squash? I can do it this during merge too. |
dnkoutso
approved these changes
Sep 29, 2020
|
Is there a getting started guide for contributing to this repo and installing the gems on Mac? I'm getting build errors with |
LemonSpike
force-pushed
the
dependency_analysis_build_phase
branch
from
127f1bf to
a3c89b7
Compare
|
@dnkoutso Rebase/squash done alongside rubocop. 😀 Hope we can merge this now. |
amorde
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #785