Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Xcode version to match Xcode 13 #857

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Bump Xcode version to match Xcode 13 #857

merged 1 commit into from
Sep 27, 2021

Conversation

efirestone
Copy link
Contributor

This avoids warnings from Xcode 13 asking to upgrade to the latest settings.

@efirestone efirestone marked this pull request as ready for review September 27, 2021 16:41
@brianmichel
Copy link

brianmichel commented Sep 27, 2021 •
edited
Loading

Is there a new version of xcodeproj we need to commit back as well?

Just realized what repo this is 🤦

@dnkoutso
Copy link
Contributor

We should update the constants.rb LAST_UPGRADE_CHECK and LAST_SWIFT_UPGRADE_CHECK to 1300 if that is what Xcode 13 uses?

@efirestone efirestone force-pushed the firestone/bump-upgrade-version branch from 24592cc to de3b08b Compare September 27, 2021 18:45
@efirestone
Copy link
Contributor Author

We should update the constants.rb LAST_UPGRADE_CHECK and LAST_SWIFT_UPGRADE_CHECK to 1300 if that is what Xcode 13 uses?

Whoops! I did, but apparently didn't hit save on that file. Updated now.

@efirestone efirestone force-pushed the firestone/bump-upgrade-version branch from de3b08b to 4ff323b Compare September 27, 2021 18:52
dnkoutso
dnkoutso reviewed Sep 27, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@efirestone efirestone force-pushed the firestone/bump-upgrade-version branch from 4ff323b to ce9758b Compare September 27, 2021 19:03
@dnkoutso dnkoutso closed this Sep 27, 2021
@dnkoutso dnkoutso reopened this Sep 27, 2021
@dnkoutso
Copy link
Contributor

Trying to kick GH actions... they seem to be slow

@efirestone efirestone force-pushed the firestone/bump-upgrade-version branch from ce9758b to 1b4a3f6 Compare September 27, 2021 23:09
@efirestone
Bump Xcode version to match Xcode 13
252e50a 
This avoids warnings from Xcode 13 asking to upgrade to the latest settings.
@efirestone efirestone force-pushed the firestone/bump-upgrade-version branch from 1b4a3f6 to 252e50a Compare September 27, 2021 23:11
@dnkoutso
Copy link
Contributor

We figured out we need to bump to Ubuntu 18 for CI.

@dnkoutso dnkoutso merged commit 9f0df21 into CocoaPods:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

@brianpartridge brianpartridge brianpartridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efirestone @brianmichel @dnkoutso @brianpartridge