-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headers option on Http download strategy #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Couple things then I think this should be good to go
This would all properly serialize to JSON and back? Remember podspecs are published as JSON to the master specs repo. |
If possible please squash to a single commit. |
Here's an example spec I've pushed to a private spec repo, I'm consuming through my fork of the downloader. This is the ...
"source": {
"http": "https://api.github.com/repos/xxx/xxx/releases/assets/xxx",
"type": "zip",
"headers": [
"Accept: application/octet-stream"
]
},
... |
01b50bf
to
413bf4f
Compare
@dnkoutso Squashed, and added a changelog entry. I've also posted an example of a private podspec I'm using at the moment which contains headers, and how it would serialize to JSON. |
Seems CI is failing, attempting to fix here #90 |
- Add an option :headers key for the caller to provide custom headers - Add HTTP headers spec - Add changelog entry for :headers option Co-authored-by: Wilmar van Heerden <github@wilmar.me> Co-authored-by: Nico du Plessis <duplessis.nico@gmail.com>
@dnkoutso I did the thing, but one of the checks is still having a bad day :-/ |
rekicked it. Probably a flake |
@wilmarvh yay! thanks! |
I can ship cocoapods-downloader 1.3 but until we ship CocoaPods 1.8.x people wont be able to use it. If you want to use this today then use https://bundler.io/ with a |
@dnkoutso Great, will do! |
@dnkoutso Hi, a friendly check-in to find out where in the greater CocoaPods roadmap 1.3 of cocoapods-downloader is pegged for? |
This pull request adds the ability to add an array of headers onto the
Http
download strategy.It was created with the goal of being able to download a release binary hosted on Github which requires the
Accept: application/octet-stream
header. However it allows for any headers to be added onto thecurl
command to be being executed.It is dependant on the following PR to be merged as well: CocoaPods/Core#557
An example of the usage looks as follows:
It also solves a bit of the frustration raised in CocoaPods/CocoaPods#5055