-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tvOS and any possible future platforms. #14
Add support for tvOS and any possible future platforms. #14
Conversation
- Include specs for missing watchos cases, tvos, and any future platform. - Update Gemfile.lock to cocoapods 0.39.0
@@ -13,26 +13,37 @@ class Search < Command | |||
CLAide::Argument.new('QUERY', true), | |||
] | |||
|
|||
def self.all_platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just define this as module_function
?
@segiddins, What do you think about adding all_platforms method to dsl.rb in cocoapods core? |
@manuyavuz I'd prefer it be a class method on Platform, personally. |
It seems good to me. I also see there is a class method I'll make class method |
Sounds perfect! |
Or perhaps |
@floere you're right, that is better! |
I get the following error while running specs:
I actually added the method to the class. Also when I run I see from trace that claide is used from default installation, not local repo. Will it cause core repo to be used from default installation also? PS: I successfully set cc: @segiddins |
Yeah, you'll need to point to your branch of core in the gemfile |
We can check correctness now because I pointed gems to updated repos. However, how we will manage it correctly? Will you update these while releasing the next release? |
Dependent PR merged, if you update the gemfile and |
635849b
to
1ea0580
Compare
@segiddins Travis fails because it needs head version of cocoapods and core. Will you merge like this and wait for release? |
Ah sorry, the Gemfile needs to be pointing to HEAD... I didn't express that well |
Sorry to repeat but I can only get a success from specs with the following Gemfile: source 'https://rubygems.org'
# Specify your gem's dependencies in cocoapods-search.gemspec
gemspec
group :development do
gem 'cocoapods', :github => 'CocoaPods/CocoaPods', :ref => 'HEAD'
gem 'cocoapods-core', :github => 'CocoaPods/Core', :ref => 'HEAD'
gem 'bacon'
gem 'mocha-on-bacon'
gem 'prettybacon'
end @segiddins Do you have any other suggestions? |
It's ready! |
:D 🚢 |
Add support for tvOS and any possible future platforms.
👍 |
Solves #11.