Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update V8 flags and force optimization #41

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

adriencaccia
Copy link
Member

@adriencaccia adriencaccia commented Dec 11, 2024

Following discussion on Discord these new changes aim to reduce variance.

Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #41 will degrade performances by 37.77%

Comparing feat/new-optimizations (7351c4e) with main (c8110bd)

Summary

⚡ 23 improvements
❌ 18 (👁 18) regressions
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/new-optimizations Change
test_iterative_fibo_10 19.6 µs 11.1 µs +76.79%
test_recursive_cached_fibo_30 47.1 µs 36.5 µs +29.32%
test sync baz 10 19.6 µs 11.6 µs +68.98%
test sync baz 100 17.5 µs 13 µs +34.47%
test_iterative_fibo_10 25.1 µs 16.6 µs +51.1%
test_recursive_cached_fibo_30 55.4 µs 41.8 µs +32.49%
test_recursive_fibo_20 3.1 ms 1.5 ms ×2.1
test sync baz 10 24.9 µs 16.1 µs +54.58%
test_iterative_fibo_10 19.7 µs 10.8 µs +82.42%
test_recursive_cached_fibo_30 50 µs 36.2 µs +37.99%
test_recursive_fibo_20 3.1 ms 1.5 ms ×2.1
test sync baz 10 19.5 µs 11.3 µs +71.65%
test sync baz 100 17.3 µs 12.2 µs +42.27%
test_iterative_fibo_10 25.1 µs 16.6 µs +51.46%
test_recursive_cached_fibo_30 52.6 µs 42 µs +25.12%
👁 test_recursive_fibo_10 26.9 µs 40.5 µs -33.6%
test sync baz 10 25.1 µs 17.1 µs +46.21%
fibo 10 23.4 µs 15 µs +55.74%
long body 383.1 µs 331.3 µs +15.61%
short body 112.2 µs 101.7 µs +10.28%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@adriencaccia adriencaccia force-pushed the feat/new-optimizations branch from 8c2fb04 to 60fc89b Compare December 11, 2024 09:28
@adriencaccia adriencaccia requested a review from art049 December 11, 2024 10:58
The flag it was setting is already passed
@adriencaccia adriencaccia merged commit 7351c4e into main Dec 11, 2024
22 checks passed
@adriencaccia adriencaccia deleted the feat/new-optimizations branch December 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants