chore(openssl): Update OpenSSL function signatures to use *mut instead of *const #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of *const This PR updates the function signatures in the `ext.rs` file to use `*mut` instead of `*const` for the `ssl` and `cert` parameters in the `SSL_use_certificate` and `SSL_use_PrivateKey` functions. This indicates that the functions can modify the SSL and certificate objects as intended. Ref: - https://www.openssl.org/docs/man1.1.1/man3/SSL_use_certificate.html https://boringssl.googlesource.com/boringssl/+/refs/tags/fips-20180730/ssl/ssl_cert.cc#292 Refactor the `cvt` function to use `c_long` instead of `c_int` for the return type for better compatibility with the types used in the OpenSSL library. Also, add a test case for the `ssl_set_groups_list` function to ensure it handles valid and invalid input correctly.
CodSpeed Performance ReportMerging #45 will not alter performanceComparing Summary
|
art049
force-pushed
the
main
branch
2 times, most recently
from
fd63f92 to
519d1f8
Compare
coco-speed
force-pushed
the
main
branch
2 times, most recently
from
e3459e9 to
21bba97
Compare
coco-speed
force-pushed
the
main
branch
2 times, most recently
from
972578d to
143f455
Compare
coco-speed
force-pushed
the
main
branch
2 times, most recently
from
5f4f3a5 to
ccdb32c
Compare
coco-speed
force-pushed
the
main
branch
4 times, most recently
from
238a17a to
fa851d6
Compare
coco-speed
force-pushed
the
main
branch
2 times, most recently
from
d94ad0d to
4b82093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically by CodSpeed to track performance changes of the pull request cloudflare/pingora#308.
The original branch is fork-308-pluveto/chore/openssl_signatures