Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loosen runtime requirements #21

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Nov 28, 2023

closes #22

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/loosen-runtime-requirements branch from 090ca40 to 8e12c62 Compare December 6, 2023 01:53
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Dec 11, 2023

CodSpeed Performance Report

Merging #21 will not alter performance

Comparing edgarrmondragon:edgarrmondragon/fix/loosen-runtime-requirements (52df364) with master (367ef47)

Summary

✅ 5 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/loosen-runtime-requirements branch from 8e12c62 to f13e157 Compare December 12, 2023 05:46
@edgarrmondragon
Copy link
Contributor Author

@art049 This is ready for another review, at your convenience

pyproject.toml Outdated Show resolved Hide resolved
@art049
Copy link
Member

art049 commented Feb 13, 2024

Looks good, I also updated slightly the documentation about why we need to install setuptools when running python 3.12+

@art049
Copy link
Member

art049 commented Feb 13, 2024

Thanks a lot @edgarrmondragon !
Sorry for the delay, we had a lot going on ;)

@art049 art049 merged commit 56e6211 into CodSpeedHQ:master Feb 13, 2024
21 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/loosen-runtime-requirements branch February 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen setuptools requirement
3 participants