Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use current checked out commit hash in UploadMetadata #18

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

adriencaccia
Copy link
Member

No description provided.

@adriencaccia adriencaccia changed the title feat: add actual_commit_hash ProviderMetadata property feat: add UploadMetadata.actual_commit_hash property and retrieve it from git Apr 23, 2024
@adriencaccia
Copy link
Member Author

@art049 you can review the aggregated file changes directly, I will squash in a single commit at the end

Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we should replace commit_hash with the commit hash from libgit and remove this actual_commit_hash.
The rest of the logic to find the "actual" commit will be handled on our backend.

@adriencaccia adriencaccia changed the title feat: add UploadMetadata.actual_commit_hash property and retrieve it from git feat: use current checked out commit hash in UploadMetadata Apr 26, 2024
@adriencaccia adriencaccia merged commit 434817d into main Apr 26, 2024
8 checks passed
@adriencaccia adriencaccia deleted the feat/actual-commit-hash branch April 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants