Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gitlab): add gitlab ci support #47

Merged
merged 8 commits into from
Nov 12, 2024
Merged

feat(gitlab): add gitlab ci support #47

merged 8 commits into from
Nov 12, 2024

Conversation

fargito
Copy link
Member

@fargito fargito commented Oct 24, 2024 •
edited
Loading

Related to: #22

@fargito fargito marked this pull request as draft October 24, 2024 13:21
@fargito fargito self-assigned this Oct 24, 2024
@fargito fargito force-pushed the feat/gitlab-ci-support branch 9 times, most recently from 43d100d to f6166af Compare October 29, 2024 12:58
@fargito fargito changed the title feat(gitlab): add gitlab support feat(gitlab): add gitlab ci support Oct 29, 2024
@fargito fargito marked this pull request as ready for review October 29, 2024 13:03
@fargito fargito requested a review from adriencaccia October 29, 2024 13:03
fargito
fargito commented Oct 29, 2024
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
@fargito fargito force-pushed the feat/gitlab-ci-support branch 6 times, most recently from e9ba710 to 1333662 Compare October 31, 2024 11:46
adriencaccia
adriencaccia requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

.vscode/settings.json Outdated Show resolved Hide resolved
src/run/ci_provider/github_actions/provider.rs Show resolved Hide resolved
src/run/ci_provider/interfaces.rs Outdated Show resolved Hide resolved
src/run/ci_provider/gitlab_ci/logger.rs Outdated Show resolved Hide resolved
src/run/ci_provider/gitlab_ci/logger.rs Outdated Show resolved Hide resolved
@fargito fargito force-pushed the feat/gitlab-ci-support branch 2 times, most recently from 7bcc9f6 to 64d104c Compare November 4, 2024 09:22
@fargito fargito requested a review from adriencaccia November 4, 2024 09:23
@fargito fargito force-pushed the feat/gitlab-ci-support branch from 64d104c to 73504cc Compare November 4, 2024 09:24
@adriencaccia adriencaccia requested a review from art049 November 4, 2024 14:02
adriencaccia
adriencaccia approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on @art049

@fargito fargito force-pushed the feat/gitlab-ci-support branch from c018dfd to e042fcc Compare November 5, 2024 14:47
art049
art049 reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP review

src/run/check_system.rs Outdated Show resolved Hide resolved
src/run/ci_provider/gitlab_ci/logger.rs Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@fargito fargito force-pushed the feat/gitlab-ci-support branch 6 times, most recently from b0e5d6f to 4906500 Compare November 6, 2024 15:13
art049
art049 requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to see how the color stuff we discussed will end up being

src/run/check_system.rs Outdated Show resolved Hide resolved
src/run/runner/valgrind/setup.rs Outdated Show resolved Hide resolved
@fargito fargito force-pushed the feat/gitlab-ci-support branch from 4906500 to 3750a41 Compare November 6, 2024 15:31
@fargito fargito force-pushed the feat/gitlab-ci-support branch 2 times, most recently from 398c4e5 to 9ce6a78 Compare November 6, 2024 15:49
@fargito fargito merged commit 9ce6a78 into main Nov 12, 2024
18 checks passed
@fargito fargito deleted the feat/gitlab-ci-support branch November 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriencaccia adriencaccia adriencaccia approved these changes

@art049 art049 art049 approved these changes

Assignees

@fargito fargito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fargito @art049 @adriencaccia