Skip to content

[Feature Request] configurable export type #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elijaholmos opened this issue Aug 31, 2022 · 9 comments · Fixed by #392
Closed

[Feature Request] configurable export type #164

elijaholmos opened this issue Aug 31, 2022 · 9 comments · Fixed by #392
Labels
good first issue Good for newcomers

Comments

@elijaholmos
Copy link
Contributor

I have a use case where I would like to change the export type of generated validation schemas from function to const. I believe the best implementation of this would be through a configuration option that defaults to function, but also accepts const as an option.

I intend on submitting a PR to implement this feature.
@github-actions github-actions bot added the good first issue Good for newcomers label Aug 31, 2022
@elijaholmos elijaholmos mentioned this issue Aug 31, 2022
Closed
@Code-Hex
Copy link
Owner

Code-Hex commented Sep 1, 2022

We're talking on #165

@Code-Hex
Copy link
Owner

@elijaholmos I'm sorry too late.
You can check some compilation errors with yarn type-check:zod now

@elijaholmos
Copy link
Contributor Author

@Code-Hex thank you! I'll do some more work on this on Monday 🙂

@elijaholmos elijaholmos mentioned this issue Jun 2, 2023
Closed
@Code-Hex Code-Hex mentioned this issue Jun 8, 2023
Merged
@Code-Hex Code-Hex closed this as completed Jun 8, 2023
@Code-Hex Code-Hex reopened this Jun 8, 2023
@Code-Hex
Copy link
Owner

Code-Hex commented Jun 8, 2023 •
edited
Loading

@elijaholmos Could you add README for validationSchemaExportType?
And I want you to fix example validationSchemaExportType configuration to function 🙏

@elijaholmos
Copy link
Contributor Author

@Code-Hex yes of course!

@Code-Hex Code-Hex mentioned this issue Jun 9, 2023
Merged
@Code-Hex
Copy link
Owner

Code-Hex commented Jun 9, 2023

@elijaholmos I handled this task.
#392

@Code-Hex
Copy link
Owner

Code-Hex commented Jun 9, 2023

I just published the latest version as v0.11.0

@elijaholmos
Copy link
Contributor Author

@Code-Hex thank you - sorry, I've had a lot to keep up with work and was going to handle this later. your help is appreciated

@Code-Hex
Copy link
Owner

Code-Hex commented Jun 9, 2023

@elijaholmos No problem 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@Code-Hex @elijaholmos