TypeError: Cannot read properties of undefined (reading 'input') #386

Giovanni-Schroevers · 2023-06-06T10:34:50Z

 TypeError: Cannot read properties of undefined (reading 'input')
        at Visitor.getScalarType (graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/visitor.js:30:40)
        at generateFieldTypeZodSchema (graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/zod/index.js:146:40)
        at generateFieldTypeZodSchema (graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/zod/index.js:135:21)
        at generateFieldTypeZodSchema (graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/zod/index.js:126:21)
        at generateFieldTypeZodSchema (graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/zod/index.js:135:21)
        at generateFieldZodSchema (graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/zod/index.js:121:17)
        at graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/zod/index.js:46:103
        at Array.map (<anonymous>)
        at Object.leave (graphcommerce/node_modules/graphql-codegen-typescript-validation-schema/dist/main/zod/index.js:46:90)
        at visit (graphcommerce/node_modules/graphql/language/visitor.js:197:21) {
      source: '../../packagesDev/next-config/src/generated/config.ts'

It seems to be a problem with nested input types. To fix the issue the following patch seems to be working:

diff --git a/node_modules/graphql-codegen-typescript-validation-schema/dist/main/visitor.js b/node_modules/graphql-codegen-typescript-validation-schema/dist/main/visitor.js
index 82da858..f2088f0 100644
--- a/node_modules/graphql-codegen-typescript-validation-schema/dist/main/visitor.js
+++ b/node_modules/graphql-codegen-typescript-validation-schema/dist/main/visitor.js
@@ -26,6 +26,9 @@ class Visitor extends typescript_1.TsVisitor {
         if (this.scalarDirection === 'both') {
             return null;
         }
+        if (!this.scalars[scalarName]) {
+            return null;
+        }
         return this.scalars[scalarName][this.scalarDirection];
     }
 }

The text was updated successfully, but these errors were encountered:

Rigo-m · 2023-06-06T13:11:54Z

Fix works, but then the types don't get generated correctly

Rigo-m · 2023-06-06T13:12:32Z

Are your scalars something like this?

 export type Scalars = {
  ID: { input: string | number; output: string; }
  String: { input: string; output: string; }
  Boolean: { input: boolean; output: boolean; }
  Int: { input: number; output: number; }
  Float: { input: number; output: number; }
  BooleanType: { input: any; output: any; }
  CustomData: { input: any; output: any; }
  DateTime: { input: any; output: any; }
  FloatType: { input: any; output: any; }
  IntType: { input: any; output: any; }
  ItemId: { input: any; output: any; }
  MetaTagAttributes: { input: any; output: any; }
  UploadId: { input: any; output: any; }
};

Code-Hex · 2023-06-06T14:05:39Z

@Giovanni-Schroevers Thanks for reporting your issue!
Could you give me your GraphQL Schema and your configuration? I want to reproduce the issue.

maoosi · 2023-06-08T06:49:23Z

Experiencing the same issue - seems to be erroring on all GraphQL Enums.

Also it is not depending on the configuration (I've tried disabling everything else apart from graphql-codegen-typescript-validation-schema and the recommended scalars config).

Example Enum:

enum Allergen {
    MILK
    EGGS
    PEANUTS
    SOY
    WHEAT
    TREE_NUTS
    SHELLFISH
    FISH
    SESAME
}

Code-Hex · 2023-06-08T10:57:59Z

@maoosi I cannot reproduce this error:

enum Allergen {
    MILK
    EGGS
    PEANUTS
    SOY
    WHEAT
    TREE_NUTS
    SHELLFISH
    FISH
    SESAME
}

then I can generate this code:

import { z } from 'zod'
import { Allergen } from '../types'

type Properties<T> = Required<{
  [K in keyof T]: z.ZodType<T[K], any, T[K]>;
}>;

type definedNonNullAny = {};

export const isDefinedNonNullAny = (v: any): v is definedNonNullAny => v !== undefined && v !== null;

export const definedNonNullAnySchema = z.any().refine((v) => isDefinedNonNullAny(v));

export const AllergenSchema = z.nativeEnum(Allergen);

and run tsc --strict --noEmit example/zod/schemas.ts

I checked w/ ee78cf3

paales · 2023-06-09T14:41:03Z

Colleague of @Giovanni-Schroevers here.

This schema gives me an error:

input InputOne {
  field: InputNested!
}

input InputNested {
  field: String
}

If I make InputNested optional, it doesn't anymore. Debugging now.

Code-Hex · 2023-06-09T14:44:27Z

@paales mmm, I could generate validation schema w/o errors:

import { z } from 'zod'
import { InputNested, InputOne } from '../types'

type Properties<T> = Required<{
  [K in keyof T]: z.ZodType<T[K], any, T[K]>;
}>;

type definedNonNullAny = {};

export const isDefinedNonNullAny = (v: any): v is definedNonNullAny => v !== undefined && v !== null;

export const definedNonNullAnySchema = z.any().refine((v) => isDefinedNonNullAny(v));

export function InputNestedSchema(): z.ZodObject<Properties<InputNested>> {
  return z.object({
    field: z.string().nullish()
  })
}

export function InputOneSchema(): z.ZodObject<Properties<InputOne>> {
  return z.object({
    field: z.lazy(() => InputNestedSchema())
  })
}

Could you give me your configuration?

paales · 2023-06-09T14:46:10Z

Digging in the code it seems related to notAllowEmptyString: true,

Code-Hex · 2023-06-09T14:46:40Z

I'm wondering if it's the same as this quickstart.
https://github.com/Code-Hex/graphql-codegen-typescript-validation-schema#quick-start

paales · 2023-06-09T14:46:45Z

Code I'm using to generate

  await generate({
    silent: true,
    schema: ['graphql/**/Config.graphqls', ...schemaLocations],
    generates: {
      [targetTs]: {
        plugins: ['typescript', 'typescript-validation-schema', 'add'],
        config: {
          // enumsAsTypes: true,
          content: '/* eslint-disable */',
          schema: 'zod',
          notAllowEmptyString: true,
          enumsAsTypes: true,
          scalarSchemas: {
            Domain: 'z.string()',
            DateTime: 'z.date()',
            RichTextAST: 'z.object.json()',
          },
        },
      },
      // ...(isMonorepo() && {
      //   '../../docs/framework/config.md': {
      //     plugins: ['@graphcommerce/graphql-codegen-markdown-docs'],
      //   },
      // }),
    },
  })

Using it here: https://github.com/graphcommerce-org/graphcommerce/blob/canary/packagesDev/next-config/src/config/commands/generateConfig.ts#L19

Code-Hex · 2023-06-09T14:49:26Z

@paales It looks to me like you didn't follow the quickstart. I want you to try it once.

generates:
  path/to/graphql.ts:
    plugins:
      - typescript
      - typescript-validation-schema # specify to use this plugin
    config:
      # You can put the config for typescript plugin here
      # see: https://www.graphql-code-generator.com/plugins/typescript
      strictScalars: true
      # Overrides built-in ID scalar to both input and output types as string.
      # see: https://the-guild.dev/graphql/codegen/plugins/typescript/typescript#scalars
      scalars:
        ID: string
      # You can also write the config for this plugin together
      schema: yup # or zod

paales · 2023-06-09T14:52:21Z

If I follow the quickstart guide it works as expected!
If I remove notAllowEmptyString: true, it works as expected :) Not ideal, but good enough for now.

Code-Hex · 2023-06-09T14:53:53Z

@paales I'm sorry, I didn't read your latest comment, I could reproduce this error 🙏
I will fix it ASAP

paales · 2023-06-09T14:55:20Z

Award for fastest responder in a GitHub issue goes to @Code-Hex! ❤️

Code-Hex · 2023-06-09T16:40:33Z

I just published the latest version as v0.11.0

maoosi · 2023-06-10T01:10:36Z

@Code-Hex Thanks! Sadly the issue still persists on my end.

Here is a reproduction link:
https://codesandbox.io/p/sandbox/mystifying-thompson-z2h8m9?welcome=true

Just run pnpm run gen to see the error:
✖ Cannot read properties of undefined (reading 'input')

Few notes:

On my dev setup, I'm running a local GraphQL Yoga server and directly introspecting it via http://127.0.0.1:4444/graphql.
Weirdly enough, I wasn’t able to reproduce the issue simply by manually re-creating the schema.graphql file.
What I had to do, is output a JSON introspection file of my local GraphQL Yoga endpoint using https://the-guild.dev/graphql/codegen/plugins/other/introspection and then use this file in the reproduction environment. This way I was able to reproduce the exact same error.

Code-Hex · 2023-06-10T04:41:39Z

@maoosi I understand why this is happening.

The generation logic relied on the schema passed from graphql-codegen. If this was a schema generated based on introspection, the astNode information was lost, so it seems that it was not possible to determine whether each schema was an enum or a scalar.

This issue was reported here:

graphql/graphql-js#1575

I will fix the logic to take this into consideration 🙏

Code-Hex · 2023-06-10T04:44:49Z

I created a new issue #394
Close this issue one.

maoosi · 2023-06-10T04:46:50Z

Awesome, thanks for looking into it!

github-actions bot added the good first issue Good for newcomers label Jun 6, 2023

Code-Hex mentioned this issue Jun 9, 2023

fix #386 #391

Merged

Code-Hex closed this as completed in 3fd4ed6 Jun 9, 2023

Code-Hex reopened this Jun 10, 2023

Code-Hex mentioned this issue Jun 10, 2023

Lost astNode in schema created by introspection query #394

Closed

Code-Hex closed this as completed Jun 10, 2023

MH4GF added a commit to MH4GF/graphql-codegen-typescript-validation-schema that referenced this issue May 26, 2024

feat: support notAllowEmptyString issue Code-Hex#386

248a35d

MH4GF added a commit to MH4GF/graphql-codegen-typescript-validation-schema that referenced this issue May 29, 2024

feat: support notAllowEmptyString issue Code-Hex#386

86dd7e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TypeError: Cannot read properties of undefined (reading 'input') #386

TypeError: Cannot read properties of undefined (reading 'input') #386

Giovanni-Schroevers commented Jun 6, 2023

Rigo-m commented Jun 6, 2023

Rigo-m commented Jun 6, 2023

Code-Hex commented Jun 6, 2023

maoosi commented Jun 8, 2023

Code-Hex commented Jun 8, 2023 •

edited

Loading

paales commented Jun 9, 2023

Code-Hex commented Jun 9, 2023 •

edited

Loading

paales commented Jun 9, 2023

Code-Hex commented Jun 9, 2023

paales commented Jun 9, 2023 •

edited

Loading

Code-Hex commented Jun 9, 2023 •

edited

Loading

paales commented Jun 9, 2023 •

edited

Loading

Code-Hex commented Jun 9, 2023

paales commented Jun 9, 2023

Code-Hex commented Jun 9, 2023

maoosi commented Jun 10, 2023 •

edited

Loading

Code-Hex commented Jun 10, 2023

Code-Hex commented Jun 10, 2023

maoosi commented Jun 10, 2023

TypeError: Cannot read properties of undefined (reading 'input') #386

TypeError: Cannot read properties of undefined (reading 'input') #386

Comments

Giovanni-Schroevers commented Jun 6, 2023

Rigo-m commented Jun 6, 2023

Rigo-m commented Jun 6, 2023

Code-Hex commented Jun 6, 2023

maoosi commented Jun 8, 2023

Code-Hex commented Jun 8, 2023 • edited Loading

paales commented Jun 9, 2023

Code-Hex commented Jun 9, 2023 • edited Loading

paales commented Jun 9, 2023

Code-Hex commented Jun 9, 2023

paales commented Jun 9, 2023 • edited Loading

Code-Hex commented Jun 9, 2023 • edited Loading

paales commented Jun 9, 2023 • edited Loading

Code-Hex commented Jun 9, 2023

paales commented Jun 9, 2023

Code-Hex commented Jun 9, 2023

maoosi commented Jun 10, 2023 • edited Loading

Code-Hex commented Jun 10, 2023

Code-Hex commented Jun 10, 2023

maoosi commented Jun 10, 2023

Code-Hex commented Jun 8, 2023 •

edited

Loading

Code-Hex commented Jun 9, 2023 •

edited

Loading

paales commented Jun 9, 2023 •

edited

Loading

Code-Hex commented Jun 9, 2023 •

edited

Loading

paales commented Jun 9, 2023 •

edited

Loading

maoosi commented Jun 10, 2023 •

edited

Loading