Skip to content

refactor: improve zod test #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2024
Merged

refactor: improve zod test #661

merged 4 commits into from
Jun 11, 2024

Conversation

MH4GF
Copy link
Contributor

@MH4GF MH4GF commented May 26, 2024

Before proceeding with the above issue, I improved the existing test that I was referring to.

  • decompose it.each : 668c47e
    • This makes it easy to run each test as a unit in the IDE.
  • Switch wantContains to toMatchInlineSnapshot: b820268
    • This makes it possible to test the entire output result.

This PR is intended as a proposal; if you do not like the content of the PR, you may dismiss it.
If the PR's are OK, I will also coordinate the testing of yup and myzod 😄

@MH4GF MH4GF changed the title improve zod test refactor: improve zod test May 26, 2024
@MH4GF MH4GF marked this pull request as ready for review May 26, 2024 00:20
@Code-Hex
Copy link
Owner

@MH4GF Could you check this PR please 🙏

@MH4GF
Copy link
Contributor Author

MH4GF commented Jun 10, 2024

@Code-Hex Sorry!I fixed it.

Copy link
Owner

@Code-Hex Code-Hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Code-Hex Code-Hex merged commit 9e19b58 into Code-Hex:main Jun 11, 2024
2 checks passed
@MH4GF MH4GF deleted the improve-zod-test branch June 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants