Skip to content

Update README.md #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Update README.md #9

merged 1 commit into from
Jan 31, 2022

Conversation

charlypoly
Copy link
Contributor

Hi @Code-Hex,

I'm Charly for The Guild, thank you again for your awesome plugin! ✨

I made the following change proposal in the attempt to fix the documentation issues on our side:

dotansimha/graphql-code-generator#7438

In short, our plugin hub system is parsing each plugin README.md as MDX.
The documentation generation (with Vercel/Next.js) fails with your plugin because of the following sentence in your README.md:

import types from generated typescript [...]

is identified by MDX as an invalid JS import expression...

I'm aware that the issue should be fixed on our side but it would be way faster to fix it this way 🏎️

Let me know what you think.

@Code-Hex
Copy link
Owner

@charlypoly Ah, I see. Thank you very much!

@Code-Hex Code-Hex merged commit 52c0666 into Code-Hex:main Jan 31, 2022
@charlypoly
Copy link
Contributor Author

@Code-Hex Thank you! ⚡

@charlypoly
Copy link
Contributor Author

@Code-Hex we will need you to publish a new version of the package 🙏🏼 (or update the existing one)

@Code-Hex
Copy link
Owner

@charlypoly I just published now. (0.1.1)

wand2016 added a commit to WORKSJAPAN/graphql-codegen-lighthouse-yup-schema that referenced this pull request Aug 16, 2024
* install pnpm

* update gitignore

* update workflows

* pnpm import

* rm yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants