-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hmt 3 navbar #2
Hmt 3 navbar #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small changes
public/MissingProfile.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image has a little background left in it. If it's difficult to perfectly clean this one up, I think it is okay to use an icon from an library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that if we used a social sign on library or google auth, we could import their profile picture. If we used an icon, I am not sure if that would be possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a great idea. If we use an icon we can conditionally swap it out for an image tag. However, we can also keep the image approach you have. I think the image would just need to be exported from figma a little cleaner
This looks good, just the svgs need to be cropped closer to the image so there's no border. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Profile SVG should have no border around it, otherwise LGTM!!
Looks good! It can be merged in |
Added the navBar component
use these variables to test the conditional rendering.