This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Fix pagination when paginate_link points to a directory #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permalink can point to a directory, and Preetzel knows it must create an index.html in that directory. This patch add support for this behavior when pagination is used. Modified custom pagination link tests to test this case.
|
Sorry for the silence, I was out of town for a few weeks. |
|
Sure. Probably I'll do it in the weekend. |
Conflicts: src/Pretzel.Logic/Templating/JekyllEngineBase.cs
|
Updated branch with upstream changes. (btw is any notification generated by updating the branch in the PR?) |
|
Thanks! |
laedit
pushed a commit
that referenced
this pull request
Aug 8, 2015
Fix pagination when paginate_link points to a directory
|
Yes that is what I meant. Then my comments (except for this one) weren't purely useless redundant spam. 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permalink can point to a directory, and Pretzel knows it must create an index.html in that directory.
This patch add support for this behavior when pagination is used.
Modified custom pagination link tests to test this case.
fixes #254