Changed date guessing heuristic to use last modification time of posts instead of current time, if no better data is available. #259
Conversation
…s instead of current time, if no better data is available. - Instead of DateTime.Now the source file's LastWriteTime is used now - The tests were updated - Updated System.IO.Abstractions and TestingHelpers to version 2.0.0.116 to avoid a bug in the System.IO.Abstractions.TestingHelpers library making tests to fail (see: TestableIO/System.IO.Abstractions#122 )
| @@ -791,21 +807,25 @@ public void page_with_false_date_in_title() | |||
| [Fact] | |||
| public void post_default_values() | |||
| { | |||
| fileSystem.AddFile(@"C:\TestSite\_posts\SomeFile.md", new MockFileData(@"--- | |||
| var filename = @"C:\TestSite\SomeFile.md"; | |||
There was a problem hiding this comment.
Why the change from Posts to Pages?
There was a problem hiding this comment.
Because the test failed. The test failed because the Posts get populated from _posts, Pages gets populated from anywhere in the site source. The path in the test vectors was not in the _posts folder (which made me wonder why the tests didn't fail earlier...). Instead of wasting hours, i changed it.
I hope I have not misunderstood something.
There was a problem hiding this comment.
Well the file path was modified from "C:\TestSite_posts\SomeFile.md" to "C:\TestSite\SomeFile.md" so it's normal that Posts is empty, but why change the file path?
|
Good one, thanks a lot! |
|
I have addressed your comments. They were totally rightful. Sorry for them, I have just recently pulled some of my changes together from my sandbox branch, and decided to send them. This PR was only sandbox-quality. |
|
No problem, thanks again for your work! 😃 |
Changed date guessing heuristic to use last modification time of posts instead of current time, if no better data is available.
Changed date guessing heuristic to use last modification time of posts instead of current time, if no better data is available.
This is a viable and better replacement as all filesystems track this, and git and other version control tools also keep track of this and set it on files on checkout.
The changes:
to avoid a bug in the System.IO.Abstractions.TestingHelpers library
making tests to fail
(see: Reading from a file via MockFileStream resets creation time TestableIO/System.IO.Abstractions#122 )