Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply termSeconds change after a term #1715

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Apply termSeconds change after a term #1715

merged 4 commits into from
Jul 23, 2019

Conversation

foriequal0
Copy link
Contributor

@foriequal0 foriequal0 commented Jul 23, 2019 •
edited
Loading

Closes: #1710

@foriequal0 foriequal0 requested review from majecty and remagpie July 23, 2019 03:32
@foriequal0 foriequal0 force-pushed the feature/term-seconds branch from 6c823a7 to 9ab1249 Compare July 23, 2019 04:31
@foriequal0 foriequal0 changed the title TermSeconds change is applied after a term Apply termSeconds change after a term Jul 23, 2019
majecty
majecty approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

remagpie
remagpie approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@remagpie remagpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foriequal0 foriequal0 merged commit 580f985 into CodeChain-io:master Jul 23, 2019
@foriequal0 foriequal0 deleted the feature/term-seconds branch July 23, 2019 06:03
@foriequal0 foriequal0 mentioned this pull request Nov 22, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majecty majecty majecty approved these changes

@remagpie remagpie remagpie approved these changes

Assignees
No one assigned
Labels
consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TermSeconds changes should be effective after a TermClose event
3 participants
@foriequal0 @majecty @remagpie