Fix the view calculation bug #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
requested changes
Oct 21, 2019
majecty
force-pushed
the
f/view
branch
2 times, most recently
from
1754b09 to
49ea602
Compare
foriequal0
requested changes
Oct 22, 2019
foriequal0
requested changes
Oct 22, 2019
foriequal0
previously approved these changes
Oct 22, 2019
When the data structure of data that is saved in the KVDB is changed, CodeChain should migrate the data. To identify the stored data structure, we need to keep a version number. This commit adds code to save and load a version number. To make the DB easier to manage, this code saves versions in the same column with the same prefix.
…lock Tendermint worker's last_confirmed_view is used for two purposes. One is the previous height's finalized view, and the other one is the current height's finalized view. This commit is part of splitting the last_confirmed_view variable.
Tendermint worker's last_confirmed_view is used for two purposes. One is the previous height's finalized view, and the other one is the current height's finalized view. This commit is part of splitting the last_confirmed_view variable.
author_view: view when the block was created. finalized_view: view when the block was finalized.
This was referenced Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1815, #1816, and #1817