Add error codes to each stratum API #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseo
reviewed
Aug 4, 2018
stratum/src/lib.rs
Outdated
| match self.dispatcher.submit((pow_hash, seal)) { | ||
| Ok(()) => { | ||
| self.update_peers(&meta.tcp_dispatcher.expect("tcp_dispatcher is always initialized")); | ||
| Ok(jsonrpc_core::Value::Bool(true)) |
There was a problem hiding this comment.
It always returns true. Let's change the return type to void.
kseo
reviewed
Aug 4, 2018
stratum/src/lib.rs
Outdated
| @@ -526,4 +528,34 @@ mod tests { | |||
| .expect("Response should be utf-8"); | |||
| assert_eq!("{\"jsonrpc\":\"2.0\",\"result\":true,\"id\":2}\n", response); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn can_occur_error_for_unauthorized_worker() { | |||
There was a problem hiding this comment.
returns_error_when_unauthorized_worker_submits
kakao-jun-e
force-pushed
the
release/startum_error
branch
from
700f3a1 to
87365d5
Compare
kseo
reviewed
Aug 4, 2018
| use jsonrpc_tcp_server::PushMessageError; | ||
| use primitives::{Bytes, H256}; | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub enum Error { | ||
| InternalError, |
There was a problem hiding this comment.
Remove Dispatch error message which is no longer used.
kakao-jun-e
force-pushed
the
release/startum_error
branch
from
87365d5 to
f85a72e
Compare
kseo
approved these changes
Aug 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #492
The error description has been changed to match the error used in the codechain-core crate and the unused error was deleted.