Remove PoW consensus #1
Conversation
sgkim126
force-pushed
the
pow
branch
2 times, most recently
from
c816527 to
6cd9101
Compare
|
This is so satisfying. |
| @@ -265,7 +239,6 @@ pub trait ConsensusEngine: Sync + Send { | |||
| header.hash() | |||
| } | |||
|
|
|||
| /// In PoW consensus, the higher scored block becomes the best block. | |||
There was a problem hiding this comment.
We may remove the "score" in the header. When using the Tendermint consensus algorithm, we can't define a valid "score" value. A finalized block must have a higher score than a proposal block. Since the content of a block is not changed whether it is finalized or not. The score always has a weird value.
There was a problem hiding this comment.
I made an issue for it.
core/src/miner/miner.rs
Outdated
| let (work, is_new) = { | ||
| let mut sealing_work = self.sealing_work.lock(); | ||
| let last_work_hash = sealing_work.queue.peek_last_ref().map(|pb| pb.block().header().hash()); | ||
| let mut sealing_work = self.sealing_work.lock(); |
There was a problem hiding this comment.
@sgkim126 What do you think about removing SealingWork and SealingQueue. IMO, they were used by PoW consensus to try to make multiple blocks' seal at the same time. When we are using the Tendermint Consensus, we only create a seal at a time.
Also in another point of view, the sealing_work.queue was needed because sealing in the PoW consensus is an asynchronous job. Creating a seal in the Tendermint consensus is a blocking job. We do not need to use the queue.
There was a problem hiding this comment.
Looks good. I'll try.
sgkim126
force-pushed
the
pow
branch
2 times, most recently
from
9b03e27 to
5e9217a
Compare
|
Travis failed because it pulls the pr for 19. I don't know why but I think it's the fault of Travis. |
It fixes #4