Skip to content

Migrate IBC transactions to use TopLevel transaction #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 12, 2020
Merged

Migrate IBC transactions to use TopLevel transaction #122

merged 5 commits into from
Feb 12, 2020

Conversation

majecty
Copy link
Contributor

@majecty majecty commented Jan 29, 2020 •
edited
Loading

The previous ics-poc implementation was using the custom action handler. Since Seulgi will remove the custom action handler, I'm porting them to use TopLevel transactions.

@majecty majecty added ics Interchain standard do-not-merge Do not merge this PR labels Jan 29, 2020
@majecty majecty changed the title [WIP] Migrate IBC transactions to use TopLevel transaction [wip] Migrate IBC transactions to use TopLevel transaction Jan 30, 2020
@majecty majecty force-pushed the f/ics-poc branch 2 times, most recently from 4186a80 to f464dd3 Compare January 31, 2020 10:52
@majecty majecty force-pushed the f/ics-poc branch 2 times, most recently from 183f1d7 to f7e27a0 Compare February 11, 2020 10:41
@majecty majecty changed the title [wip] Migrate IBC transactions to use TopLevel transaction Migrate IBC transactions to use TopLevel transaction Feb 12, 2020
@majecty majecty requested a review from junha1 February 12, 2020 05:43
@majecty
Copy link
Contributor Author

majecty commented Feb 12, 2020

@junha1 Could you check this PR?
You don't need to read code line by line.
Just check which files are changed and which struct is created and removed.

@majecty majecty mentioned this pull request Feb 12, 2020
Merged
@majecty majecty merged commit c8fa869 into CodeChain-io:ics-poc Feb 12, 2020
@majecty majecty deleted the f/ics-poc branch February 12, 2020 08:32
@majecty majecty removed the do-not-merge Do not merge this PR label Feb 12, 2020
@majecty majecty mentioned this pull request Feb 12, 2020
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junha1 junha1 Awaiting requested review from junha1

Assignees
No one assigned
Labels
ics Interchain standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@majecty