Adapt e2e tests to the new foundry-rpc #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majecty
requested changes
Jan 31, 2020
MSNTCS
force-pushed
the
master
branch
3 times, most recently
from
49012bd to
d3baef1
Compare
majecty
requested changes
Feb 3, 2020
There was a problem hiding this comment.
Please be careful about what you added in a commit.
You must not add unrelated code change in a commit.
You can use git add -p command or CLion's tool to select only the diff you need to add in a commit.
These links will help you:
https://gist.github.com/mattlewissf/9958704
https://blog.jetbrains.com/idea/2018/02/intellij-idea-2018-1-eap-partial-git-commits-and-more/
Also, I wrote a help message in our wiki about this:
https://github.com/kodebox-io/kodebox-internal/wiki/Tips-for-Developers#selectively-stage-your-work
MSNTCS
force-pushed
the
master
branch
3 times, most recently
from
f456beb to
76a396b
Compare
MSNTCS
changed the title
majecty
requested changes
Feb 3, 2020
MSNTCS
changed the title
majecty
requested changes
Feb 5, 2020
MSNTCS
force-pushed
the
master
branch
2 times, most recently
from
ebb3bc6 to
9c46d4c
Compare
MSNTCS
commented
Feb 7, 2020
majecty
requested changes
Feb 10, 2020
majecty
previously approved these changes
Feb 10, 2020
MSNTCS
force-pushed
the
master
branch
2 times, most recently
from
65cc284 to
25d3bb0
Compare
MSNTCS
force-pushed
the
master
branch
3 times, most recently
from
7bed25e to
1f1f893
Compare
majecty
previously approved these changes
Feb 11, 2020
majecty
approved these changes
Feb 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.