Remove unused verification code #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was empty. We will make Foundry verify seal in a header soon. When verifying a seal, we should not use ConsensusEngine. Since the Tendermint ConsensusEngine uses a global lock, ConsensusEngine::verify_block_seal would not utilize multi threads.
The VerificationQueue does not read the variable.
Foundry was using only the VerifierType::Canon.
Foundry is using only CanonVerifier. We are not using the `Verifier` abstraction.
sgkim126
approved these changes
Apr 16, 2020
|
Since the failed test is "connect 100 nodes" I merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.