net: mctp: usb: Fix In Transfer Parsing #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upcoming changes will add both a USB host- and gadget driver for the MCTP-over-USB protocol. Add a header that provides common definitions across both of these: the packet header format and a few framing definitions. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Add an implementation for DMTF DSP0283, which defines a MCTP-over-USB transport. We're restricted to full speed mode, requiring 512-byte transfers. WIP. Still todo: - power management - skb/urb pre-allocation Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Add a USB function for gthe device side of DMTF DSP0283, for a MCTP-over-USB transport. WIP; needs more testing in error paths. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Add a configfs option for the USB gadget function: tx_batch_delay. When non-zero, will wait delay milliseconds for further packets to be transmitted, and potentially batch those packets into a single USB transfer. Intended for testing only; helps to excersise the host-side driver's packet parsing. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Fixes the following: * Endian-ness of the MCTP USB binding header (DMTF ID) * Getting the binding header from the URB. Tested: Tested on a hardware that supports MCTP over USB. MCTP Control commands work fine after fixes. Signed-off-by: Santosh Puranik <santosh.puranik@gmail.com>
jk-ozlabs
force-pushed
the
dev/mctp-usb
branch
2 times, most recently
from
f02c4b5
to
c71b33b
Compare
|
Closing, the new branch fixed most of the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
Tested:
Tested on a hardware that supports MCTP over USB.
MCTP Control commands work fine after fixes.