Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Hide terminal title change command while creating new terminal #1387

Closed
Cubik65536 opened this issue Jul 20, 2023 · 0 comments · Fixed by #1388
Closed

✨ Hide terminal title change command while creating new terminal #1387

Cubik65536 opened this issue Jul 20, 2023 · 0 comments · Fixed by #1388
Labels
enhancement New feature or request

Comments

@Cubik65536
Copy link
Contributor

Description

In PR #1298 , some shell integration scripts have been added so the terminal's title would change according to the program running. As a downside, a source command and a clear command would been shown every time a new terminal has been created (refer to the screenshot below). We have to find a way to have these things running somewhere where the user can't see them.

Alternatives Considered

No response

Additional Context

I'm already looking into this problem:

The current idea is to add another install script like what iTerm is using.

The current source command have a downside, which is it have to be run in the current shell process, so, if we don't hide the terminal outputs while it's running, it just have to be shown to the user.

On the other hand, the script like what iTerm is using can be run anywhere because it's detecting if the user's source file (~/.zshrc, etc.) contains the right integration script, and if they don't, add the source command to those file, so this script can be executed in any terminal (we can create a terminal without a view for that), and our shell integration scripts would always be loaded even there's no extra commands executed in that exact shell. But we'll have to write something in user's shell's source file. (We chose not to do this when implementing #1298 , but I think it's the best solution that I can come up with for now.)

Screenshots

image
@Cubik65536 Cubik65536 added the enhancement New feature or request label Jul 20, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project Aug 2, 2023
bombardier200 pushed a commit that referenced this issue Aug 2, 2023
* feat: Set `TERM_PROGRAM` for terminal

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* style: Replace unnecessary `var` with `let`

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Improve Shell Integration Setup Process

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* style: Fix SwiftLint Errors

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* style: Fix Trailing Whitespace Violation

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

---------

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

1 participant