Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Increase/Decrease Font Size command one step behind #1396

Closed
austincondiff opened this issue Aug 2, 2023 · 1 comment · Fixed by #1403 or #1609
Closed

🐞 Increase/Decrease Font Size command one step behind #1396

austincondiff opened this issue Aug 2, 2023 · 1 comment · Fixed by #1403 or #1609
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Aug 2, 2023 •
edited
Loading

Description

Consecutive increase/decrease font size commands, and then reversing once continues in the same direction on the first execution. Subsequent times works as expected. As an example:

To Reproduce

Key Pressed Result
⌘+ Font increases
⌘+ Font increases
⌘+ Font increases
⌘- Font increases
⌘- Font decreases
⌘- Font decreases
⌘+ Font decreases
⌘+ Font increases

Expected Behavior

Key Pressed Result
⌘+ Font increases
⌘+ Font increases
⌘+ Font increases
⌘- Font decreases
⌘- Font decreases
⌘- Font decreases
⌘+ Font increases
⌘+ Font increases

Version Information

CodeEdit: 0.0.3-alpha (36)

Additional Context

Related issues:
@austincondiff austincondiff added the bug Something isn't working label Aug 2, 2023
@austincondiff austincondiff changed the title 🐞 Increase/Decrease Font Size command one step behind. 🐞 Increase/Decrease Font Size command one step behind Aug 2, 2023
@austincondiff austincondiff moved this from 🆕 New to 📋 Todo in CodeEdit Project Aug 2, 2023
@austincondiff austincondiff added the good first issue Good for newcomers label Aug 2, 2023
@Ahattalla Ahattalla mentioned this issue Aug 13, 2023
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from 📋 Todo to 🏁 Complete in CodeEdit Project Aug 14, 2023
@austincondiff austincondiff reopened this Jan 6, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Complete to 📋 Todo in CodeEdit Project Jan 6, 2024
@austincondiff
Copy link
Collaborator Author

austincondiff commented Jan 6, 2024 •
edited
Loading

Reopening because we have regressed on this issue and it needs to be fixed again.

ibrahimcetin added a commit to ibrahimcetin/CodeEdit that referenced this issue Mar 10, 2024
@ibrahimcetin
Fix font resize CodeEditApp#1396
e7d1e52
@ibrahimcetin ibrahimcetin mentioned this issue Mar 10, 2024
Merged
6 tasks
austincondiff pushed a commit that referenced this issue Mar 11, 2024
@ibrahimcetin
Fixed delay in synchronization of font size increment and decrement (#…
7c773f9 
…1609)

* Fix font resize #1396

* Improve readability

* Remove deprecated code
@github-project-automation github-project-automation bot moved this from 📋 Todo to 🏁 Complete in CodeEdit Project Mar 11, 2024
FastestMolasses pushed a commit to Angelk90/CodeEdit that referenced this issue Apr 11, 2024
@ibrahimcetin @FastestMolasses
Fixed delay in synchronization of font size increment and decrement (C…
f0a689a 
…odeEditApp#1609)

* Fix font resize CodeEditApp#1396

* Improve readability

* Remove deprecated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
1 participant
@austincondiff